Messages in this thread | | | Date | Mon, 29 Nov 2021 10:01:45 -0800 | From | Roman Gushchin <> | Subject | Re: [PATCH] mm/memcg: Relocate mod_objcg_mlstate(), get_obj_stock() and put_obj_stock() |
| |
On Mon, Nov 29, 2021 at 11:11:40AM -0500, Waiman Long wrote: > All the calls to mod_objcg_mlstate(), get_obj_stock() and put_obj_stock() > are done by functions defined within the same "#ifdef CONFIG_MEMCG_KMEM" > compilation block. When CONFIG_MEMCG_KMEM isn't defined, the following > compilation warnings will be issued [1] and [2]. > > mm/memcontrol.c:785:20: warning: unused function 'mod_objcg_mlstate' > mm/memcontrol.c:2113:33: warning: unused function 'get_obj_stock' > > Fix these warning by moving those functions to under the same > CONFIG_MEMCG_KMEM compilation block. There is no functional change. > > [1] https://lore.kernel.org/lkml/202111272014.WOYNLUV6-lkp@intel.com/ > [2] https://lore.kernel.org/lkml/202111280551.LXsWYt1T-lkp@intel.com/ > > Fixes: 559271146efc ("mm/memcg: optimize user context object stock access") > Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Waiman Long <longman@redhat.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
| |