Messages in this thread | | | Date | Mon, 29 Nov 2021 08:34:06 -0800 | From | Keith Busch <> | Subject | Re: [PATCH] nvme: duplicate NQNs check if devices needed |
| |
On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote: > @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn) > > lockdep_assert_held(&nvme_subsystems_lock); > > + if (strncmp(subsysnqn, "nqn.", 4)) > + return NULL;
This seems like an arbitrary way to decide not to check for duplicates. Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the broken controllers?
| |