lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nvme: duplicate NQNs check if devices needed
On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote:
> @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>
> lockdep_assert_held(&nvme_subsystems_lock);
>
> + if (strncmp(subsysnqn, "nqn.", 4))
> + return NULL;

This seems like an arbitrary way to decide not to check for duplicates.
Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the
broken controllers?

\
 
 \ /
  Last update: 2021-11-29 17:37    [W:0.063 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site