Messages in this thread Patch in this message | | | From | Leon Romanovsky <> | Subject | [PATCH net-next v1] devlink: Remove misleading internal_flags from health reporter dump | Date | Sun, 28 Nov 2021 14:14:46 +0200 |
| |
From: Leon Romanovsky <leonro@nvidia.com>
DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback and has no use in internal_flags at all. Remove this misleading assignment.
Fixes: e44ef4e4516c ("devlink: Hang reporter's dump method on a dumpit cb") Signed-off-by: Leon Romanovsky <leonro@nvidia.com> --- v1: * Sent as standalone change v0: https://lore.kernel.org/all/cover.1637173517.git.leonro@nvidia.com --- net/core/devlink.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c index d144a62cbf73..fd21022145a3 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -8845,8 +8845,6 @@ static const struct genl_small_ops devlink_nl_ops[] = { GENL_DONT_VALIDATE_DUMP_STRICT, .dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit, .flags = GENL_ADMIN_PERM, - .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT | - DEVLINK_NL_FLAG_NO_LOCK, }, { .cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR, -- 2.33.1
| |