Messages in this thread | | | Date | Sun, 28 Nov 2021 10:53:06 +0100 | Subject | Re: [PATCH v2 14/20] mfd: intel_soc_pmic_chtwc: Add intel_cht_wc_get_model() helper function | From | Hans de Goede <> |
| |
Hi,
On 11/16/21 12:18, Andy Shevchenko wrote: > On Sun, Nov 14, 2021 at 7:04 PM Hans de Goede <hdegoede@redhat.com> wrote: >> >> Tablet / laptop designs using an Intel Cherry Trail x86 main SoC with >> an Intel Whiskey Cove PMIC do not use a single standard setup for > > does not
designs ... do not. Design_s_ so more then one, so "do not" is correct.
<snip>
>> +} >> +EXPORT_SYMBOL_GPL(intel_cht_wc_get_model); > > Are you planning to use EXPORT_SYMBOL_GPL_NS()? If not, please consider it.
This will be gone in v3, since this info is now stored in struct intel_soc_pmic as requested by Chanwoo.
Regards,
Hans
| |