lkml.org 
[lkml]   [2021]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/7] net-next: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
On Thu, Nov 18, 2021 at 11:09:55AM +0800, Biao Huang wrote:
> Dear Matthias,
> Agree, converting and changes should be seperated.
>
> There are some changes in the driver, but mediatek-dwmac.txt
>
> is not updated for a long time, and is not accurate enough.
>
> So this patch is more like a new yaml replace the old txt,
> than a word-to-word converting.
>
>
> Anyway, only 3 little changes compare to old mediate-dwmac.txt, others
> almost keep the same:
> 1. compatible " const: snps,dwmac-4.20"
> 2. delete "snps,reset-active-low;" in example, since driver
> remove this property long ago.
> 3. add "snps,reset-delays-us = <0 10000 10000>;" in example,
>
> Should I split this patch?
> If yes, I'll split in next send.
> Thanks.

It's fine with one patch, but describe the changes in the commit msg.

Rob

\
 
 \ /
  Last update: 2021-11-29 01:03    [W:0.049 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site