Messages in this thread Patch in this message | | | Date | Sun, 28 Nov 2021 18:00:08 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf tools: remove unneeded variable |
| |
On Mon, Nov 22, 2021 at 01:41:59AM +0000, cgel.zte@gmail.com wrote: > From: ran jianping <ran.jianping@zte.com.cn> > > Fix the following coccicheck review: > ./tools/perf/util/evlist.c:1303:5-8: Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, jirka
> --- > tools/perf/util/evlist.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 5f92319ce258..d64fe767f583 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -1300,7 +1300,6 @@ static int evlist__create_syswide_maps(struct evlist *evlist) > { > struct perf_cpu_map *cpus; > struct perf_thread_map *threads; > - int err = -ENOMEM; > > /* > * Try reading /sys/devices/system/cpu/online to get > @@ -1325,7 +1324,7 @@ static int evlist__create_syswide_maps(struct evlist *evlist) > out_put: > perf_cpu_map__put(cpus); > out: > - return err; > + return -ENOMEM; > } > > int evlist__open(struct evlist *evlist) > -- > 2.25.1 >
| |