Messages in this thread | | | From | Sam Protsenko <> | Date | Sun, 28 Nov 2021 18:26:24 +0200 | Subject | Re: [PATCH 4/8] tty: serial: samsung: Remove USI initialization |
| |
On Sun, 28 Nov 2021 at 16:28, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Sun, Nov 28, 2021 at 12:32:49AM +0200, Sam Protsenko wrote: > > USI control is now extracted to dedicated USIv2 driver. Remove USI > > related code from serial driver to avoid conflicts and code duplication. > > What conflicts? >
There might be possible conflicts when accessing the same USI register from both serial driver and USIv2 driver. Also there will be conflicts when trying to access the same I/O address space in those both drivers.
> What duplication? All you did here was delete code. >
It's all explained in [PATCH 0/8], but long story short, I've added USIv2 driver (in this series) which handles the code that's removed from serial driver in this patch.
> confused, > > greg k-h
| |