lkml.org 
[lkml]   [2021]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mei: Remove some dead code
On Sun, Nov 28, 2021 at 11:12:33AM +0000, Winkler, Tomas wrote:
>
> >
> >
> > > On 12 Nov 2021, at 11:06, Christophe JAILLET
> > <christophe.jaillet@wanadoo.fr> wrote:
> > >
> > > 'generated' is known to be true here, so "true || whatever" will still
> > > be true.
> > >
> > > So, remove some dead code.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > ---
> > > This is also likely that a bug is lurking here.
> > >
> > > Maybe, the following was expected:
> > > - generated = generated ||
> > > + generated =
> > > (hisr & HISR_INT_STS_MSK) ||
> > > (ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > >
> > > ?
> >
> > I concur about your analysis, but I do not know the intent here.
> Your fix is okay, I can ack that patch.

Is that an ack of this patch? If so, please provide that...

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-11-28 15:33    [W:0.073 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site