lkml.org 
[lkml]   [2021]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] iio: ltr501: Export near level property for proximity sensor
On Thu, 25 Nov 2021 17:56:46 +0500
Nikita Travkin <nikita@trvn.ru> wrote:

> Userspace tools like iio-sensor-proxy need to know the proximity level
> that should be considered "near". This value is hardware-specific and
> can be defined via the devicetree. Allow the driver to export the near
> level.
>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>

Hi Nikita,

This looks fine to me, but I'd like to leave a little time for others
to look including DT review.

Thanks,

Jonathan

>
> ---
> The changes are mostly copied from vcnl4000 patchset introducing the
> property:
> https://lore.kernel.org/linux-iio/cover.1586094535.git.agx@sigxcpu.org/
> ---
> drivers/iio/light/ltr501.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> index 64ba04c275e8..47d61ec2bb50 100644
> --- a/drivers/iio/light/ltr501.c
> +++ b/drivers/iio/light/ltr501.c
> @@ -166,6 +166,7 @@ struct ltr501_data {
> struct regmap_field *reg_ps_rate;
> struct regmap_field *reg_als_prst;
> struct regmap_field *reg_ps_prst;
> + uint32_t near_level;
> };
>
> static const struct ltr501_samp_table ltr501_als_samp_table[] = {
> @@ -525,6 +526,25 @@ static int ltr501_write_intr_prst(struct ltr501_data *data,
> return -EINVAL;
> }
>
> +static ssize_t ltr501_read_near_level(struct iio_dev *indio_dev,
> + uintptr_t priv,
> + const struct iio_chan_spec *chan,
> + char *buf)
> +{
> + struct ltr501_data *data = iio_priv(indio_dev);
> +
> + return sprintf(buf, "%u\n", data->near_level);
> +}
> +
> +static const struct iio_chan_spec_ext_info ltr501_ext_info[] = {
> + {
> + .name = "nearlevel",
> + .shared = IIO_SEPARATE,
> + .read = ltr501_read_near_level,
> + },
> + { /* sentinel */ }
> +};
> +
> static const struct iio_event_spec ltr501_als_event_spec[] = {
> {
> .type = IIO_EV_TYPE_THRESH,
> @@ -609,6 +629,7 @@ static const struct iio_chan_spec ltr501_channels[] = {
> },
> .event_spec = ltr501_pxs_event_spec,
> .num_event_specs = ARRAY_SIZE(ltr501_pxs_event_spec),
> + .ext_info = ltr501_ext_info,
> },
> IIO_CHAN_SOFT_TIMESTAMP(3),
> };
> @@ -1531,6 +1552,10 @@ static int ltr501_probe(struct i2c_client *client,
> if ((partid >> 4) != data->chip_info->partid)
> return -ENODEV;
>
> + if (device_property_read_u32(&client->dev, "proximity-near-level",
> + &data->near_level))
> + data->near_level = 0;
> +
> indio_dev->info = data->chip_info->info;
> indio_dev->channels = data->chip_info->channels;
> indio_dev->num_channels = data->chip_info->no_channels;

\
 
 \ /
  Last update: 2021-11-27 19:46    [W:0.074 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site