lkml.org 
[lkml]   [2021]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net] ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce()
From
Date
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 26 Nov 2021 18:55:43 +0100 you wrote:
> ethtool_set_coalesce() now uses both the .get_coalesce() and
> .set_coalesce() callbacks. But the check for their availability is
> buggy, so changing the coalesce settings on a device where the driver
> provides only _one_ of the callbacks results in a NULL pointer
> dereference instead of an -EOPNOTSUPP.
>
> Fix the condition so that the availability of both callbacks is
> ensured. This also matches the netlink code.
>
> [...]

Here is the summary with links:
- [net] ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce()
https://git.kernel.org/netdev/net/c/0276af2176c7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


\
 
 \ /
  Last update: 2021-11-26 20:49    [W:0.043 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site