Messages in this thread | | | Subject | Re: [PATCH net] ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce() | From | patchwork-bot+netdevbpf@kernel ... | Date | Fri, 26 Nov 2021 19:30:09 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>:
On Fri, 26 Nov 2021 18:55:43 +0100 you wrote: > ethtool_set_coalesce() now uses both the .get_coalesce() and > .set_coalesce() callbacks. But the check for their availability is > buggy, so changing the coalesce settings on a device where the driver > provides only _one_ of the callbacks results in a NULL pointer > dereference instead of an -EOPNOTSUPP. > > Fix the condition so that the availability of both callbacks is > ensured. This also matches the netlink code. > > [...]
Here is the summary with links: - [net] ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce() https://git.kernel.org/netdev/net/c/0276af2176c7
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |