Messages in this thread | | | Date | Fri, 26 Nov 2021 19:18:18 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH 7/7] net: dsa: b53: Expose PTP timestamping ioctls to userspace |
| |
On Fri, Nov 26, 2021 at 09:03:48AM -0800, Richard Cochran wrote: > On Fri, Nov 26, 2021 at 06:42:57PM +0200, Vladimir Oltean wrote: > > I'm still missing something obvious, aren't I? > > You said there are "many more" drivers with this bug, but I'm saying > that most drivers correctly upgrade the ioctl request. > > So far we have b53 and ocelot doing the buggy downgrade. I guess it > will require a tree wide audit to discover the "many more"...
Ah, yes, I assure you that there are many more drivers doing wacky stuff, for example sja1105 will take any RX filter that isn't NONE, and then reports it back as PTP_V2_L2_EVENT. https://elixir.bootlin.com/linux/latest/source/drivers/net/dsa/sja1105/sja1105_ptp.c#L89
Somehow at this stage I don't even want to know about any other drivers, since I might feel the urge to patch them and I don't really have the necessary free time for that right now :D
| |