Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 26 Nov 2021 17:02:00 +0200 | Subject | Re: [PATCH v4 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs |
| |
On Fri, Nov 26, 2021 at 4:10 PM Henning Schild <henning.schild@siemens.com> wrote: > > This driver adds initial support for several devices from Siemens. It is > based on a platform driver introduced in an earlier commit.
...
> +static struct simatic_ipc_led simatic_ipc_leds_mem[] = { > + {0x500 + 0x1A0, "red:" LED_FUNCTION_STATUS "-1"}, > + {0x500 + 0x1A8, "green:" LED_FUNCTION_STATUS "-1"}, > + {0x500 + 0x1C8, "red:" LED_FUNCTION_STATUS "-2"}, > + {0x500 + 0x1D0, "green:" LED_FUNCTION_STATUS "-2"}, > + {0x500 + 0x1E0, "red:" LED_FUNCTION_STATUS "-3"}, > + {0x500 + 0x198, "green:" LED_FUNCTION_STATUS "-3"}, > + { } > +};
Like I said, this is not okay.
Why can't you simply enable the pinctrl driver and use it?
-- With Best Regards, Andy Shevchenko
| |