lkml.org 
[lkml]   [2021]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] mac80211: fix suspicious RCU usage in ieee80211_set_tx_power()
From
Date
On Mon, 2021-11-15 at 14:09 +0800, Bixuan Cui wrote:
>
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 1ab8483..14fbe9e 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -2702,14 +2702,19 @@ static int ieee80211_set_tx_power(struct wiphy *wiphy,
> enum nl80211_tx_power_setting txp_type = type;
> bool update_txp_type = false;
> bool has_monitor = false;
> + int ret = 0;
> +
> + rtnl_lock();
>

This will almost certainly result in lockups, or at least lockdep
complaints, that's just wrong.

johannes

\
 
 \ /
  Last update: 2021-11-26 13:40    [W:0.032 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site