lkml.org 
[lkml]   [2021]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] nfc: virtual_ncidev: change default device permissions
From
Date
 On 25/11/2021 15:14, Thadeu Lima de Souza Cascardo wrote:
> Device permissions is S_IALLUGO, with many unnecessary bits. Remove them
> and also remove read and write permissions from group and others.
>
> Before the change:
> crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci
>
> After the change:
> crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
> drivers/nfc/virtual_ncidev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c
> index 221fa3bb8705..f577449e4935 100644
--- a/drivers/nfc/virtual_ncidev.c
> +++ b/drivers/nfc/virtual_ncidev.c
> @@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void)
> miscdev.minor = MISC_DYNAMIC_MINOR;
> miscdev.name = "virtual_nci";
> miscdev.fops = &virtual_ncidev_fops;
> - miscdev.mode = S_IALLUGO;
> + miscdev.mode = 0600;
>
> return misc_register(&miscdev);
> }
> --

Reviewed-by: Bongsu Jeon <bongsu.jeon@samsung.com>


Thanks.

\
 
 \ /
  Last update: 2021-11-26 07:14    [W:0.060 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site