Messages in this thread | | | Date | Fri, 26 Nov 2021 10:40:55 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH v2 4/9] watchdog: move watchdog sysctl interface to watchdog.c |
| |
On Tue 2021-11-23 12:23:42, Luis Chamberlain wrote: > From: Xiaoming Ni <nixiaoming@huawei.com> > > The kernel/sysctl.c is a kitchen sink where everyone leaves > their dirty dishes, this makes it very difficult to maintain. > > To help with this maintenance let's start by moving sysctls to > places where they actually belong. The proc sysctl maintainers > do not want to know what sysctl knobs you wish to add for your own > piece of code, we just care about the core logic of proc sysctl. > > So, move the watchdog syscl interface to watchdog.c. > Use register_sysctl() to register the sysctl interface to avoid > merge conflicts when different features modify sysctl.c at the > same time. > > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com> > Reviewed-by: Kees Cook <keescook@chromium.org> > [mcgrof: justify the move on the commit log] > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |