Messages in this thread | | | Subject | Re: [PATCH v1 1/2] modpost: file2alias: fixup mdio alias garbled code in modules.alias | From | zhuyinbo <> | Date | Fri, 26 Nov 2021 17:34:36 +0800 |
| |
在 2021/11/23 下午9:54, Andrew Lunn 写道: >>>> Hi Andrew, >>>> >>>> Use default mdio configure, After module compilation, mdio alias configure >>>> is following and it doesn't match >>>> >>>> the match phy dev(mdio dev) uevent, because the mdio alias configure >>>> "0000000101000001000011111001????" include "?" and >>> A PHY ID generally break up into 3 parts. >>> >>> The OUI of the manufacture. >>> The device. >>> The revision >>> >>> The ? means these bits don't matter. Those correspond to the >>> revision. Generally, a driver can driver any revision of the PHY, >>> which is why those bits don't matter. >>> >>> So when a driver probes with the id 00000001010000010000111110010110 >>> we expect user space to find the best match, performing wildcard >>> expansion. So the ? will match anything. >>> >>> Since this is worked for a long time, do you have an example where it >>> is broken? If so, which PHY driver? If it is broken, no driver is >>> loaded, or the wrong driver is loaded, i expect it is a bug in a >>> specific driver. And we should fix that bug in the specific driver. >>> >>> Andrew >> Hi Andrew, >> >> The string like "0000000101000001000011111001????" dont't match any mdio driver, and i said it include "? that "?" doesn't match any driver, in addition that include Binary digit >> like "0000000101000001000011111001", that binary digit doesn't match any driver, that should use Hexadecimal for phy id, and I test on some platform, not only a platform, it isn't some >> specifi driver issue, it is gerneral issue. please you note. that phy driver match phy device must use whole string "MODALIAS=xxxyyzz", not partial match. > Please give a concrete example. Show us udev logs of it not working, > it failing to find a match. > > Andrew
Hi Andrew,
I don't get udev log, but I can find that phy module wether be load by lsmod ways, and you can try
it in any a phy deice and in any arch platform. in addition, I will send v2 version patch that need consider
some phy device doesn't follow IEEE802.3 protocol strictly and doesn't read phy id from phy register successfully,
please review.
Brs,
Yinbo Zhu.
| |