lkml.org 
[lkml]   [2021]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [RESEND] fscache: re-match MODULE_PARM_DESC() calls to module parameters
On Mon Sep  6 13:00:41 2021 Nicolas Schier wrote:
> Fix calls of MODULE_PARM_DESC() such that the first argument matches
> the
> actual module parameter name. This changes the 'parm' section in the
> output of `modinfo fscache` from:
>
> parm: defer_lookup:uint
> parm: fscache_defer_lookup:Defer cookie lookup to background thread
> parm: defer_create:uint
> parm: fscache_defer_create:Defer cookie creation to background thread
> parm: debug:uint
> parm: fscache_debug:FS-Cache debugging mask
>
> into:
>
> parm: defer_lookup:Defer cookie lookup to background thread (uint)
> parm: defer_create:Defer cookie creation to background thread (uint)
> parm: debug:FS-Cache debugging mask (uint)
> .
>
> Signed-off-by: Nicolas Schier <nicolas@fjasle.eu>
> ---
> fs/fscache/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --
> Resend unmodified as list approval for linux-cachefs@r.c timed out.
>
> diff --git a/fs/fscache/main.c b/fs/fscache/main.c
> index c1e6cc9091aa..ccb06dc0a6e9 100644
> --- a/fs/fscache/main.c
> +++ b/fs/fscache/main.c
> @@ -22,19 +22,19 @@ MODULE_LICENSE("GPL");
> unsigned fscache_defer_lookup = 1;
> module_param_named(defer_lookup, fscache_defer_lookup, uint,
> S_IWUSR | S_IRUGO);
> -MODULE_PARM_DESC(fscache_defer_lookup,
> +MODULE_PARM_DESC(defer_lookup,
> "Defer cookie lookup to background thread");
>
> unsigned fscache_defer_create = 1;
> module_param_named(defer_create, fscache_defer_create, uint,
> S_IWUSR | S_IRUGO);
> -MODULE_PARM_DESC(fscache_defer_create,
> +MODULE_PARM_DESC(defer_create,
> "Defer cookie creation to background thread");
>
> unsigned fscache_debug;
> module_param_named(debug, fscache_debug, uint,
> S_IWUSR | S_IRUGO);
> -MODULE_PARM_DESC(fscache_debug,
> +MODULE_PARM_DESC(debug,
> "FS-Cache debugging mask");
>
> struct kobject *fscache_root;
> --
> 2.30.1

David, I got no feedback on this here, yet. Shall I fix something or
is there anything wrong with the patch?

Kind regards,
Nicolas
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-11-26 08:51    [W:0.068 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site