lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: split thp synchronously on MADV_DONTNEED
On Thu, Nov 25, 2021 at 09:14:30AM -0800, Shakeel Butt wrote:
> On Thu, Nov 25, 2021 at 2:09 AM Peter Xu <peterx@redhat.com> wrote:
> >
> [...]
> >
> > Hi, Shakeel,
> >
> > I saw your v2 has started to pass in zap_details, then we need know the side
> > effect on that skip-swap-entry thing because with your v2 code munmap() will
> > start to skip swap entry too (while it was not before).
> >
> > I saw that you didn't mention this in v2 patch either in commit message or
> > code, not sure whether you digged that up. I think it needs some double check
> > (or feel free to start this digging by reviewing my small patch above :).
> >
>
> I remember mentioning in the patch that this has dependency on your
> rfc patch. Just checked again and yeah I only mentioned in the
> 'changes since v1' section. I will add it more explicitly in the
> following versions.

Apologize for missing that section. Yeah depending on that patch should work.

>
> I will take a close look at your patch as well.

Thanks a lot,

--
Peter Xu

\
 
 \ /
  Last update: 2021-11-26 01:03    [W:0.088 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site