lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 4/4] mfd: ti_am335x_tscadc: drop the CNTRLREG_TSC_8WIRE macro
    Date
    In TI's reference manual description for the `AFE_Pen_Ctrl' bit-field
    of the TSC's CTRL register, there is no mention of 8-wire touchscreens.
    Even commit f0933a60d190 ("mfd: ti_am335x_tscadc: Update logic in CTRL
    register for 5-wire TS") says that the value of this bit-field must be
    the same for 4-wire and 8-wire touchscreens. So let's remove the
    CNTRLREG_TSC_8WIRE macro to avoid misunderstandings.

    Signed-off-by: Dario Binacchi <dariobin@libero.it>

    ---

    Changes in v2:
    - Replace CNTRLREG_8WIRE with CNTRLREG_TSC_8WIRE. In the meantime, the
    file ti_am335x_tscadc.h has been modified, so the patch must be
    updated.

    include/linux/mfd/ti_am335x_tscadc.h | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
    index ba13e043d910..4063b0614d90 100644
    --- a/include/linux/mfd/ti_am335x_tscadc.h
    +++ b/include/linux/mfd/ti_am335x_tscadc.h
    @@ -103,7 +103,6 @@
    #define CNTRLREG_TSC_AFE_CTRL(val) FIELD_PREP(GENMASK(6, 5), (val))
    #define CNTRLREG_TSC_4WIRE CNTRLREG_TSC_AFE_CTRL(1)
    #define CNTRLREG_TSC_5WIRE CNTRLREG_TSC_AFE_CTRL(2)
    -#define CNTRLREG_TSC_8WIRE CNTRLREG_TSC_AFE_CTRL(3)
    #define CNTRLREG_TSC_ENB BIT(7)

    /*Control registers bitfields for MAGADC IP */
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-11-26 00:03    [W:3.345 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site