Messages in this thread | | | Date | Fri, 26 Nov 2021 09:36:56 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH] pata_falcon: Add missing __iomem annotations |
| |
On Thu, 25 Nov 2021, Geert Uytterhoeven wrote:
> > Yeah, you do have to be careful with macros that derive a size from the > type of the passed data. The *{in,out}sw() functions do not suffer from > that: they are defined to operate on a 16-bit I/O register. It is very > unlikely these semantics will ever change. > > Here I'm more worried about the other danger: keeping casts will silence > any warning that may be introduced in a future change to the driver > code. >
Fair enough. I'll send v2.
| |