lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/3] hwmon: (nct6775) Implement custom lock by ACPI mutex.
    On Thu, 25 Nov 2021 at 20:54, Guenter Roeck <linux@roeck-us.net> wrote:
    > We won't be heving two drivers with the same functionality. Give me one
    > reason why I should not drop the wmi driver (or both of them; I am not
    > sure which one we are talking about here).
    >
    > On top of all that, this submission isn't about any of the wmi drivers,
    > but for the nct6775 driver, which just adds to the confusion.

    Let me try to explain once again, please. I began to dig into the ASUS
    sensors and how to read their values and at first found the WMI
    function to do that, wrote a driver and Denis submitted it as
    asus_wmi_ec_sensors. Now, I know a better and simpler way to read
    those sensors, which uses ACPI mutex directly. I suggested Denis to
    use the mutex way for the nct6775 driver for motherboards without WMI
    functions to read from the nct chip. With that change entering the nct
    driver, I want to submit my updated driver for EC sensors, replacing
    the asus_wmi_ec_sensors code (which is essentially my old driver).

    So, now I ask to rename asus_wmi_sensors to asus_ec_sensors (source
    file and KBuild options) already before 5.16 is released, because the
    updated code, which I will submit later, and which will replace that
    in asus_wmi_ec_sensors.c, does not use WMI.

    Hope this clarifies my request and intention.

    Best regards,
    Eugene

    \
     
     \ /
      Last update: 2021-11-25 21:08    [W:5.068 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site