lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] IB/mthca: Cleanup and optimize a few bitmap operation
On Wed, Nov 24, 2021 at 09:40:09PM +0100, Christophe JAILLET wrote:
> Patch 1 and 2 are just cleanups that uses 'bitmap_zalloc()' and 'bitmap_set()'
> instead of hand-writing these functions.
>
> Patch 3 and 4 are more questionable. They replace calls to '[set|clear]_bit()'
> by their non-atomic '__[set|clear]_bit()' alternatives.
> In both files, it looks safe to do so because accesses to the corresponding
> bitmaps are protected by spinlocks.
> However, these patches are compile tested only. It not sure it worth changing the
> code just for saving a few atomic operations.
> So review, test and apply only if it make sense.
>
> Christophe JAILLET (4):
> IB/mthca: Use bitmap_zalloc() when applicable
> IB/mthca: Use bitmap_set() when applicable
> IB/mthca: Use non-atomic bitmap functions when possible in
> 'mthca_allocator.c'
> IB/mthca: Use non-atomic bitmap functions when possible in
> 'mthca_mr.c'

Applied to for-next, thanks

Jason

\
 
 \ /
  Last update: 2021-11-25 18:32    [W:0.063 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site