Messages in this thread | | | Subject | Re: [PATCH 2/2] get_maintainer: ignore "my" e-mail address | From | Joe Perches <> | Date | Thu, 25 Nov 2021 09:01:30 -0800 |
| |
(I dislike my email client sometimes, apologies for the blank reply)
On Thu, 2021-11-25 at 17:14 +0100, Lukasz Stelmach wrote: > It was <2021-11-16 wto 15:14>, when Joe Perches wrote: > > On Tue, 2021-11-16 at 22:34 +0100, Łukasz Stelmach wrote: > > > Ignore one's own e-mail address given as a parameter to --ignore-me > > > or in the EMAIL environment variable. > > > > Why is this useful? > > > > git send-email already supports this. > > > > --suppress-cc=<category> > > Specify an additional category of recipients to suppress > > the auto-cc of: > > > > • author will avoid including the patch author > > > > • self will avoid including the sender > > > > --[no-]suppress-from > > If this is set, do not add the From: address to the cc: > > list. Default is the value of sendemail.suppressFrom > > configuration value; if that is unspecified, default to > > --no-suppress-from. > > > > Not really, git send-email does not support --suppress-to, and with > get_maintainers.pl coupled with git send-email as follows > > --8<---------------cut here---------------start------------->8--- > [sendemail] > tocmd = "`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nol --" > cccmd = "`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nom --nor --nofixes --" > --8<---------------cut here---------------end--------------->8--- > > my address is added to To: if I am a maintainer of the patched files. > To avoid this the --ignore-me options can be added to tocmd.
Rather than add complexity to the original get_maintainer script, is it possible to add a pipe like " | grep -v '<your_address>'" to tocmd ?
I think it better to have these cmds use scripts ala:
https://lore.kernel.org/all/1473862411.32273.25.camel@perches.com/
And if not a script and the complexity is warranted (though I think not) I'd rather have something like --suppress-addresss "<addr>" added to get_maintainer.pl to allow one or more addresses to be suppressed.
| |