lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next] ASoC: SOF: mediatek: Add missing of_node_put() in platform_parse_resource()
    Date
    The node pointer is returned by of_parse_phandle() with
    refcount incremented in platform_parse_resource(). Calling
    of_node_put() to aovid the refcount leak.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    ---
    sound/soc/sof/mediatek/mt8195/mt8195.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/soc/sof/mediatek/mt8195/mt8195.c b/sound/soc/sof/mediatek/mt8195/mt8195.c
    index 40e5a25875a6..55d9812870a4 100644
    --- a/sound/soc/sof/mediatek/mt8195/mt8195.c
    +++ b/sound/soc/sof/mediatek/mt8195/mt8195.c
    @@ -43,6 +43,7 @@ static int platform_parse_resource(struct platform_device *pdev, void *data)
    }

    ret = of_address_to_resource(mem_region, 0, &res);
    + of_node_put(mem_region);
    if (ret) {
    dev_err(dev, "of_address_to_resource dma failed\n");
    return ret;
    @@ -64,6 +65,7 @@ static int platform_parse_resource(struct platform_device *pdev, void *data)
    }

    ret = of_address_to_resource(mem_region, 0, &res);
    + of_node_put(mem_region);
    if (ret) {
    dev_err(dev, "of_address_to_resource sysmem failed\n");
    return ret;
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-11-25 08:11    [W:2.415 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site