Messages in this thread | | | Date | Thu, 25 Nov 2021 17:41:07 +0100 | From | Greg KH <> | Subject | Re: [PATCH] staging: r8188eu: remove unused hal fields |
| |
On Wed, Nov 17, 2021 at 02:20:20PM +0000, Zameer Manji wrote: > Several HAL related fields are never used or are useless. This removes > those fields and any code that is now safe to remove from the field > deletion. > > The fields that are referenced but are useless are: > * interfaceIndex: only written to, never read. > * CurrentCckTxPwrIdx: only written to, never read. > * CurrentOfdm24GTxPwrIdx: only written to, never read. > * CurrentBW2024GTxPwrIdx: only written to, never read. > * CurrentBW4024GTxPwrIdx: only written to, never read. > * bRDGEnable: never initialized, always false.
Please split this up into one-patch-per-thing, this is very hard to read and verify that this is all correct when it is lumped together.
Make it a patch series and resend please.
thanks,
greg k-h
| |