Messages in this thread | | | Date | Thu, 25 Nov 2021 14:30:45 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v11 3/5] arm64: Make the unwind loop in unwind() similar to other architectures |
| |
On Tue, Nov 23, 2021 at 01:37:21PM -0600, madvenka@linux.microsoft.com wrote:
> unwind_start(&frame, fp, pc); > while (unwind_continue(tsk, &frame, fn, data)) > unwind_next(tsk, &frame);
Other architectures seem to call their unwind_next() unwind_next_frame() instead, and use a function unwind_done() rather than unwind_continue(). I appreciate that's actually a change carried through from one of the earlier patches but might be worth considering. I don't really *mind* that, though if there's any work on pulling more code out of the architecture into the generic code it'll need revisiting in at least some of the architectures.
Reviwed-by: Mark Brown <broonie@kernel.org> [unhandled content-type:application/pgp-signature] | |