Messages in this thread | | | Date | Thu, 25 Nov 2021 11:48:13 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] media: i2c: dw9714: add optional regulator support |
| |
On Thu, Nov 25, 2021 at 09:09:22AM +0100, Martin Kepplinger wrote:
> + dw9714_dev->vcc = devm_regulator_get_optional(&client->dev, "vcc"); > + if (IS_ERR(dw9714_dev->vcc)) { > + if (PTR_ERR(dw9714_dev->vcc) != -ENODEV)
This looks like an abuse of regulator_get_optiona(), unless the supply might be physically absent in a system it should be using a normal regulator_get(). [unhandled content-type:application/pgp-signature] | |