Messages in this thread | | | Date | Thu, 25 Nov 2021 13:40:21 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v14] tty: Fix the keyboard led light display problem |
| |
On Thu, Nov 25, 2021 at 10:33:23AM +0800, lianzhi chang wrote: > > > On Mon, Nov 08, 2021 at 01:51:39PM +0800, lianzhi chang wrote: > > > > Switching from the desktop environment to the tty environment, > > > > the state of the keyboard led lights and the state of the keyboard > > > > lock are inconsistent. This is because the attribute kb->kbdmode > > > > of the tty bound in the desktop environment (Xorg) is set to > > > > VC_OFF, which causes the ledstate and kb->ledflagstate > > > > We know that Xorg sets kbdmode mode to VC_OFF, but it does not mean that > > > you can say for sure that it is Xorg instance that controls a VT simply > > > by observing kb->kbdmode. There may be something else entirely. That is > > > why you want drivers/tty/vt/keyboard.c to reset LEDs and leave it to > > > whoever is controlling VT to set them to something else if it is > > > desired. > > > Does this mean let me change the description information? Or is the > > judgment of VC_OFF in patch incorrect? > > The setup method of Xorg mentioned here is just to describe a process > > in which I found the problem; > > My understanding is that when the mode of kbdmode is set to VC_OFF, > > VT shouldn't interfere with the state of the keyboard light, right? This is > > how functions such as kbd_keycode() are implemented. > > When VT is switched, if the VT mode is VC_OFF, there is also no need > > to set the state of the keyboard light. I think this is reasonable. > > > > > > values of the bound tty to always be 0, which causes the switch > > > > > from the desktop When to the tty environment, the LED light > > > > > status is inconsistent with the keyboard lock status. > > > > > In order to ensure that the keyboard LED lights are displayed > > > > > normally during the VT switching process, when the VT is > > > > > switched, the current VT LED configuration is forced to be issued.
> Hi friends, how is this patch progressing now, do I need to modify it further?
At least I have told you already twice that I'm not the guy who suggested this solution. Others seem gave you other comments.
-- With Best Regards, Andy Shevchenko
| |