Messages in this thread | | | Date | Thu, 25 Nov 2021 21:28:23 -0600 | From | Corey Minyard <> | Subject | Re: [PATCH] ipmi: fix oob access due to uninit smi_msg type |
| |
On Thu, Nov 25, 2021 at 07:05:43AM -0800, Jakub Kicinski wrote: > On Thu, 25 Nov 2021 08:21:40 -0600 Corey Minyard wrote: > > On Wed, Nov 24, 2021 at 01:03:23PM -0800, Jakub Kicinski wrote: > > > We're hitting OOB accesses in handle_ipmb_direct_rcv_rsp() (memcpy of > > > size -1) after user space generates a message. Looks like the message > > > is incorrectly assumed to be of the new IPMB type, because type is never > > > set and message is allocated with kmalloc() not kzalloc(). > > > > > > Fixes: 059747c245f0 ("ipmi: Add support for IPMB direct messages") > > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > > > This is correct, and in my queue. Thanks for the fix. > > Where is your queue, BTW? I see not T entry in MAINTAINERS and nothing > of note in the github tree from which you send PRs.
It's at github.com:cminyard/linux-ipmi.git for-next
I hadn't pushed it up yet, I wanted to do some testing. I just pushed it.
-corey
| |