lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 026/323] cavium: Return negative value when pci_alloc_irq_vectors() fails
    Date
    From: Zheyu Ma <zheyuma97@gmail.com>

    [ Upstream commit b2cddb44bddc1a9c5949a978bb454bba863264db ]

    During the process of driver probing, the probe function should return < 0
    for failure, otherwise, the kernel will treat value > 0 as success.

    Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c
    index 90497a27df184..7c0a67f1f43f7 100644
    --- a/drivers/net/ethernet/cavium/thunder/nic_main.c
    +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
    @@ -1175,7 +1175,7 @@ static int nic_register_interrupts(struct nicpf *nic)
    dev_err(&nic->pdev->dev,
    "Request for #%d msix vectors failed, returned %d\n",
    nic->num_vec, ret);
    - return 1;
    + return ret;
    }

    /* Register mailbox interrupt handler */
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:53    [W:3.181 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site