lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 236/251] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag
    Date
    From: Rustam Kovhaev <rkovhaev@gmail.com>

    commit 34dbc3aaf5d9e89ba6cc5e24add9458c21ab1950 upstream.

    When kmemleak is enabled for SLOB, system does not boot and does not
    print anything to the console. At the very early stage in the boot
    process we hit infinite recursion from kmemleak_init() and eventually
    kernel crashes.

    kmemleak_init() specifies SLAB_NOLEAKTRACE for KMEM_CACHE(), but
    kmem_cache_create_usercopy() removes it because CACHE_CREATE_MASK is not
    valid for SLOB.

    Let's fix CACHE_CREATE_MASK and make kmemleak work with SLOB

    Link: https://lkml.kernel.org/r/20211115020850.3154366-1-rkovhaev@gmail.com
    Fixes: d8843922fba4 ("slab: Ignore internal flags in cache creation")
    Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>
    Acked-by: Vlastimil Babka <vbabka@suse.cz>
    Reviewed-by: Muchun Song <songmuchun@bytedance.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Glauber Costa <glommer@parallels.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    mm/slab.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/mm/slab.h
    +++ b/mm/slab.h
    @@ -146,7 +146,7 @@ static inline unsigned long kmem_cache_f
    #define SLAB_CACHE_FLAGS (SLAB_NOLEAKTRACE | SLAB_RECLAIM_ACCOUNT | \
    SLAB_TEMPORARY | SLAB_ACCOUNT)
    #else
    -#define SLAB_CACHE_FLAGS (0)
    +#define SLAB_CACHE_FLAGS (SLAB_NOLEAKTRACE)
    #endif

    /* Common flags available with current configuration */

    \
     
     \ /
      Last update: 2021-11-24 13:48    [W:4.046 / U:1.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site