lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 234/251] tun: fix bonding active backup with arp monitoring
    Date
    From: Nicolas Dichtel <nicolas.dichtel@6wind.com>

    commit a31d27fbed5d518734cb60956303eb15089a7634 upstream.

    As stated in the bonding doc, trans_start must be set manually for drivers
    using NETIF_F_LLTX:
    Drivers that use NETIF_F_LLTX flag must also update
    netdev_queue->trans_start. If they do not, then the ARP monitor will
    immediately fail any slaves using that driver, and those slaves will stay
    down.

    Link: https://www.kernel.org/doc/html/v5.15/networking/bonding.html#arp-monitor-operation
    Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/tun.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/net/tun.c
    +++ b/drivers/net/tun.c
    @@ -858,6 +858,7 @@ static netdev_tx_t tun_net_xmit(struct s
    {
    struct tun_struct *tun = netdev_priv(dev);
    int txq = skb->queue_mapping;
    + struct netdev_queue *queue;
    struct tun_file *tfile;
    u32 numqueues = 0;

    @@ -916,6 +917,10 @@ static netdev_tx_t tun_net_xmit(struct s
    if (skb_array_produce(&tfile->tx_array, skb))
    goto drop;

    + /* NETIF_F_LLTX requires to do our own update of trans_start */
    + queue = netdev_get_tx_queue(dev, txq);
    + queue->trans_start = jiffies;
    +
    /* Notify and wake up reader process */
    if (tfile->flags & TUN_FASYNC)
    kill_fasync(&tfile->fasync, SIGIO, POLL_IN);

    \
     
     \ /
      Last update: 2021-11-24 13:47    [W:4.036 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site