lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 117/207] scsi: dc395: Fix error case unwinding
    Date
    From: Tong Zhang <ztong0001@gmail.com>

    [ Upstream commit cbd9a3347c757383f3d2b50cf7cfd03eb479c481 ]

    dc395x_init_one()->adapter_init() might fail. In this case, the acb is
    already cleaned up by adapter_init(), no need to do that in
    adapter_uninit(acb) again.

    [ 1.252251] dc395x: adapter init failed
    [ 1.254900] RIP: 0010:adapter_uninit+0x94/0x170 [dc395x]
    [ 1.260307] Call Trace:
    [ 1.260442] dc395x_init_one.cold+0x72a/0x9bb [dc395x]

    Link: https://lore.kernel.org/r/20210907040702.1846409-1-ztong0001@gmail.com
    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Reviewed-by: Finn Thain <fthain@linux-m68k.org>
    Signed-off-by: Tong Zhang <ztong0001@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/dc395x.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
    index 830b2d2dcf206..8490d0ff04ca7 100644
    --- a/drivers/scsi/dc395x.c
    +++ b/drivers/scsi/dc395x.c
    @@ -4809,6 +4809,7 @@ static int dc395x_init_one(struct pci_dev *dev, const struct pci_device_id *id)
    /* initialise the adapter and everything we need */
    if (adapter_init(acb, io_port_base, io_port_len, irq)) {
    dprintkl(KERN_INFO, "adapter init failed\n");
    + acb = NULL;
    goto fail;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:40    [W:4.680 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site