lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 022/251] cavium: Fix return values of the probe function
    Date
    From: Zheyu Ma <zheyuma97@gmail.com>

    [ Upstream commit c69b2f46876825c726bd8a97c7fa852d8932bc32 ]

    During the process of driver probing, the probe function should return < 0
    for failure, otherwise, the kernel will treat value > 0 as success.

    Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/cavium/thunder/nicvf_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
    index 98734a37b6f64..df1c4ba7e0c97 100644
    --- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c
    +++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
    @@ -1152,7 +1152,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic)
    if (ret < 0) {
    netdev_err(nic->netdev,
    "Req for #%d msix vectors failed\n", nic->num_vec);
    - return 1;
    + return ret;
    }

    sprintf(nic->irq_name[irq], "%s Mbox", "NICVF");
    @@ -1171,7 +1171,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic)
    if (!nicvf_check_pf_ready(nic)) {
    nicvf_disable_intr(nic, NICVF_INTR_MBOX, 0);
    nicvf_unregister_interrupts(nic);
    - return 1;
    + return -EIO;
    }

    return 0;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:33    [W:4.046 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site