lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 093/162] serial: 8250_dw: Drop wrong use of ACPI_PTR()
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    [ Upstream commit ebabb77a2a115b6c5e68f7364b598310b5f61fb2 ]

    ACPI_PTR() is more harmful than helpful. For example, in this case
    if CONFIG_ACPI=n, the ID table left unused which is not what we want.

    Instead of adding ifdeffery here and there, drop ACPI_PTR().

    Fixes: 6a7320c4669f ("serial: 8250_dw: Add ACPI 5.0 support")
    Reported-by: Daniel Palmer <daniel@0x0f.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Link: https://lore.kernel.org/r/20211005134516.23218-1-andriy.shevchenko@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/8250/8250_dw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
    index 039837db65fcc..f3ed1eeaed4e1 100644
    --- a/drivers/tty/serial/8250/8250_dw.c
    +++ b/drivers/tty/serial/8250/8250_dw.c
    @@ -607,7 +607,7 @@ static struct platform_driver dw8250_platform_driver = {
    .name = "dw-apb-uart",
    .pm = &dw8250_pm_ops,
    .of_match_table = dw8250_of_match,
    - .acpi_match_table = ACPI_PTR(dw8250_acpi_match),
    + .acpi_match_table = dw8250_acpi_match,
    },
    .probe = dw8250_probe,
    .remove = dw8250_remove,
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:12    [W:4.067 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site