lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 021/162] spi: spl022: fix Microwire full duplex mode
    Date
    From: Thomas Perrot <thomas.perrot@bootlin.com>

    [ Upstream commit d81d0e41ed5fe7229a2c9a29d13bad288c7cf2d2 ]

    There are missing braces in the function that verify controller parameters,
    then an error is always returned when the parameter to select Microwire
    frames operation is used on devices allowing it.

    Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
    Link: https://lore.kernel.org/r/20211022142104.1386379-1-thomas.perrot@bootlin.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-pl022.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
    index 5e5fd77e27119..e294f21db2068 100644
    --- a/drivers/spi/spi-pl022.c
    +++ b/drivers/spi/spi-pl022.c
    @@ -1710,12 +1710,13 @@ static int verify_controller_parameters(struct pl022 *pl022,
    return -EINVAL;
    }
    } else {
    - if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX)
    + if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) {
    dev_err(&pl022->adev->dev,
    "Microwire half duplex mode requested,"
    " but this is only available in the"
    " ST version of PL022\n");
    - return -EINVAL;
    + return -EINVAL;
    + }
    }
    }
    return 0;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:03    [W:3.741 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site