lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V4 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk
From
Hello Stefano,

Thanks for your review and advices, I will fix them

Thanks,
Zhu Lingshan

On 11/24/2021 11:39 PM, Stefano Garzarella wrote:
> Hi Zhu,
>
> On Mon, Apr 19, 2021 at 8:39 AM Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>> This series enabled Intel FGPA SmartNIC C5000X-PL virtio-blk for vDPA.
> Looking at the IFCVF upstream vDPA driver (with this series applied), it
> seems that there is still some cleaning to be done to support virtio-blk
> devices:
>
> - ifcvf_vdpa_get_config() and ifcvf_vdpa_set_config() use
> `sizeof(struct virtio_net_config)` to check the inputs.
> This seems wrong for a virtio-blk device. Maybe we can set the config
> size for each device in ifcvf_vdpa_dev_add() and use that field to
> check the inputs. We can reuse the same field also in
> ifcvf_vdpa_get_config_size().
>
> - Just for make the code more readable we should rename `net_cfg` field
> to `device_cfg`in `struct ifcvf_hw`.
>
> What do you think?
>
> Thanks,
> Stefano
>

\
 
 \ /
  Last update: 2021-11-25 03:15    [W:0.149 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site