Messages in this thread | | | From | Nicolas Frattaroli <> | Subject | Re: [PATCH v2] ASoC: rockchip: i2s_tdm: Dup static DAI template | Date | Wed, 24 Nov 2021 23:34:01 +0100 |
| |
On Mittwoch, 24. November 2021 22:21:45 CET Nicolas Frattaroli wrote: > Previously, the DAI template was used directly, which lead to > fun bugs such as "why is my channels_max changing?" when one > instantiated more than one i2s_tdm IP block in a device tree. > > This change makes it so that we instead duplicate the template > struct, and then use that. > > Fixes: 081068fd6414 ("ASoC: rockchip: add support for i2s-tdm controller") > Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Disregard that, this patch is broken too because I still use i2s_tdm_dai elsewhere in the code. I'll respin it in a v3 when I've actually slept enough to not make these mistakes.
Sorry for the needless e-mail noise.
Regards, Nicolas Frattaroli
| |