Messages in this thread | | | Date | Wed, 24 Nov 2021 22:35:24 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds |
| |
On Wed, Nov 24, 2021 at 09:20:46PM +0100, David Heidelberg wrote: > Both are already used by HW and drivers inside Linux. > > Fix warnings as: > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] > From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml > > Signed-off-by: David Heidelberg <david@ixit.cz>
This is valid for the binding, but not all Linux implementations of fixed-link support > 1G. Only the phylink one does. But that is outside the scope of the binding document.
You probably should list all speeds in drivers/net/phy/phy-core.c:phy_setting settings[]. They are all valid when using phylink and fixed-link.
Andrew
| |