lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases
On Wed, 24 Nov 2021 at 19:46, John Keeping <john@metanate.com> wrote:
>
> This series is prompted by discussion on a previous patch set [1] but is
> a totally different approach and only a partial solution.
>
> With these patches, the dependency on the mshcN alias is totally removed
> from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves
> towards being able to consider the mshcN aliases deprecated.
>
> I haven't changed dw_mci_hi6220_caps here, although it looks like it's
> possible to apply MMC_CAP_CMD23 to all controllers there with no change
> in behaviour as the final entry is SDIO for which CMD23 is not
> applicable IIUC. But I'm not familiar with that hardware and don't feel
> confident making that change.
>
> [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/
>
> John Keeping (4):
> mmc: dw_mmc: add common capabilities to replace caps
> mmc: dw_mmc: hi3798cv200: use common_caps
> mmc: dw_mmc: rockchip: use common_caps
> mmc: dw_mmc: exynos: use common_caps
>
> drivers/mmc/host/dw_mmc-exynos.c | 9 +++++----
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +--------
> drivers/mmc/host/dw_mmc-rockchip.c | 11 +----------
> drivers/mmc/host/dw_mmc.c | 3 +++
> drivers/mmc/host/dw_mmc.h | 3 +++
> 5 files changed, 13 insertions(+), 22 deletions(-)
>
> --
> 2.34.0
>

This looks good to me, I intend to apply this later this week, unless
objections of course.

In the meantime, I will continue to look at what we can do to resolve
the exynos/k3 issues around this.

Kind regards
Uffe

\
 
 \ /
  Last update: 2021-11-24 20:26    [W:0.110 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site