lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] selftests: skip mincore.check_file_mmap when fs lacks needed support
    Date
    Report mincore.check_file_mmap as SKIP instead of FAIL if the underlying
    filesystem lacks support of O_TMPFILE or fallocate since such failures
    are not really related to mincore functionality.

    Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
    ---
    This can happen especially on test-automation systems where rootfs can
    be configured as being on NFS or virtual disks.
    ---
    .../selftests/mincore/mincore_selftest.c | 20 +++++++++++++------
    1 file changed, 14 insertions(+), 6 deletions(-)

    diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c
    index e54106643337..4c88238fc8f0 100644
    --- a/tools/testing/selftests/mincore/mincore_selftest.c
    +++ b/tools/testing/selftests/mincore/mincore_selftest.c
    @@ -207,15 +207,21 @@ TEST(check_file_mmap)

    errno = 0;
    fd = open(".", O_TMPFILE | O_RDWR, 0600);
    - ASSERT_NE(-1, fd) {
    - TH_LOG("Can't create temporary file: %s",
    - strerror(errno));
    + if (fd < 0) {
    + ASSERT_EQ(errno, EOPNOTSUPP) {
    + TH_LOG("Can't create temporary file: %s",
    + strerror(errno));
    + }
    + SKIP(goto out_free, "O_TMPFILE not supported by filesystem.");
    }
    errno = 0;
    retval = fallocate(fd, 0, 0, FILE_SIZE);
    - ASSERT_EQ(0, retval) {
    - TH_LOG("Error allocating space for the temporary file: %s",
    - strerror(errno));
    + if (retval) {
    + ASSERT_EQ(errno, EOPNOTSUPP) {
    + TH_LOG("Error allocating space for the temporary file: %s",
    + strerror(errno));
    + }
    + SKIP(goto out_close, "fallocate not supported by filesystem.");
    }

    /*
    @@ -271,7 +277,9 @@ TEST(check_file_mmap)
    }

    munmap(addr, FILE_SIZE);
    +out_close:
    close(fd);
    +out_free:
    free(vec);
    }

    --
    2.17.1
    \
     
     \ /
      Last update: 2021-11-24 17:22    [W:2.489 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site