Messages in this thread | | | Date | Wed, 24 Nov 2021 15:36:06 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq |
| |
On Thu, 28 Oct 2021, Claudiu Beznea wrote:
> Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation > mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might > be connected critical devices (like PMIC) which on suspend/resume should > be suspended/resumed at the end/beginning. i2c uses > .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom > to use .resume_noirq as it should be resumed before the embedded IPs. > Otherwise the embedded devices might behave badly. > > Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Tested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/mfd/atmel-flexcom.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |