lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/11] ASoC: cs35l41: Create function for init array of Supplies
On Tue, Nov 23, 2021 at 05:58:59PM +0000, Mark Brown wrote:
> On Tue, Nov 23, 2021 at 04:31:42PM +0000, Lucas Tanure wrote:

> > + ret = regulator_bulk_enable(CS35L41_NUM_SUPPLIES, supplies);
> > + if (ret != 0) {
> > + dev_err(dev, "Failed to enable core supplies: %d\n", ret);
> > + return ret;
> > + }

> Where's the matching disable, I didn't see anything in the HDA code? It
> is there in cs35l41_remove() in the CODEC driver but there's nothing
> sharing that bit of code here that I noticed.

Relatedly, given that the HDA stuff will most likely only be used on
ACPI systems are you sure it needs to handle regulators at all?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-11-24 15:08    [W:0.056 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site