lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 158/279] net: dpaa2-eth: fix use-after-free in dpaa2_eth_remove
    Date
    From: Pavel Skripkin <paskripkin@gmail.com>

    [ Upstream commit 9b5a333272a48c2f8b30add7a874e46e8b26129c ]

    Access to netdev after free_netdev() will cause use-after-free bug.
    Move debug log before free_netdev() call to avoid it.

    Fixes: 7472dd9f6499 ("staging: fsl-dpaa2/eth: Move print message")
    Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
    index 7065c71ed7b86..f3e443f2d9cf9 100644
    --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
    +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
    @@ -4538,10 +4538,10 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev)

    fsl_mc_portal_free(priv->mc_io);

    - free_netdev(net_dev);
    -
    dev_dbg(net_dev->dev.parent, "Removed interface %s\n", net_dev->name);

    + free_netdev(net_dev);
    +
    return 0;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:58    [W:4.348 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site