lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 134/279] MIPS: generic/yamon-dt: fix uninitialized variable error
    Date
    From: Colin Ian King <colin.i.king@googlemail.com>

    [ Upstream commit 255e51da15baed47531beefd02f222e4dc01f1c1 ]

    In the case where fw_getenv returns an error when fetching values
    for ememsizea and memsize then variable phys_memsize is not assigned
    a variable and will be uninitialized on a zero check of phys_memsize.
    Fix this by initializing phys_memsize to zero.

    Cleans up cppcheck error:
    arch/mips/generic/yamon-dt.c:100:7: error: Uninitialized variable: phys_memsize [uninitvar]

    Fixes: f41d2430bbd6 ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
    Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/generic/yamon-dt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/mips/generic/yamon-dt.c b/arch/mips/generic/yamon-dt.c
    index a3aa22c77cadc..a07a5edbcda78 100644
    --- a/arch/mips/generic/yamon-dt.c
    +++ b/arch/mips/generic/yamon-dt.c
    @@ -75,7 +75,7 @@ static unsigned int __init gen_fdt_mem_array(
    __init int yamon_dt_append_memory(void *fdt,
    const struct yamon_mem_region *regions)
    {
    - unsigned long phys_memsize, memsize;
    + unsigned long phys_memsize = 0, memsize;
    __be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES];
    unsigned int mem_entries;
    int i, err, mem_off;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:55    [W:4.115 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site