lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 142/279] RDMA/core: Set send and receive CQ before forwarding to the driver
    Date
    From: Leon Romanovsky <leonro@nvidia.com>

    [ Upstream commit 6cd7397d01c4a3e09757840299e4f114f0aa5fa0 ]

    Preset both receive and send CQ pointers prior to call to the drivers and
    overwrite it later again till the mlx4 is going to be changed do not
    overwrite ibqp properties.

    This change is needed for mlx5, because in case of QP creation failure, it
    will go to the path of QP destroy which relies on proper CQ pointers.

    BUG: KASAN: use-after-free in create_qp.cold+0x164/0x16e [mlx5_ib]
    Write of size 8 at addr ffff8880064c55c0 by task a.out/246

    CPU: 0 PID: 246 Comm: a.out Not tainted 5.15.0+ #291
    Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014
    Call Trace:
    dump_stack_lvl+0x45/0x59
    print_address_description.constprop.0+0x1f/0x140
    kasan_report.cold+0x83/0xdf
    create_qp.cold+0x164/0x16e [mlx5_ib]
    mlx5_ib_create_qp+0x358/0x28a0 [mlx5_ib]
    create_qp.part.0+0x45b/0x6a0 [ib_core]
    ib_create_qp_user+0x97/0x150 [ib_core]
    ib_uverbs_handler_UVERBS_METHOD_QP_CREATE+0x92c/0x1250 [ib_uverbs]
    ib_uverbs_cmd_verbs+0x1c38/0x3150 [ib_uverbs]
    ib_uverbs_ioctl+0x169/0x260 [ib_uverbs]
    __x64_sys_ioctl+0x866/0x14d0
    do_syscall_64+0x3d/0x90
    entry_SYSCALL_64_after_hwframe+0x44/0xae

    Allocated by task 246:
    kasan_save_stack+0x1b/0x40
    __kasan_kmalloc+0xa4/0xd0
    create_qp.part.0+0x92/0x6a0 [ib_core]
    ib_create_qp_user+0x97/0x150 [ib_core]
    ib_uverbs_handler_UVERBS_METHOD_QP_CREATE+0x92c/0x1250 [ib_uverbs]
    ib_uverbs_cmd_verbs+0x1c38/0x3150 [ib_uverbs]
    ib_uverbs_ioctl+0x169/0x260 [ib_uverbs]
    __x64_sys_ioctl+0x866/0x14d0
    do_syscall_64+0x3d/0x90
    entry_SYSCALL_64_after_hwframe+0x44/0xae

    Freed by task 246:
    kasan_save_stack+0x1b/0x40
    kasan_set_track+0x1c/0x30
    kasan_set_free_info+0x20/0x30
    __kasan_slab_free+0x10c/0x150
    slab_free_freelist_hook+0xb4/0x1b0
    kfree+0xe7/0x2a0
    create_qp.part.0+0x52b/0x6a0 [ib_core]
    ib_create_qp_user+0x97/0x150 [ib_core]
    ib_uverbs_handler_UVERBS_METHOD_QP_CREATE+0x92c/0x1250 [ib_uverbs]
    ib_uverbs_cmd_verbs+0x1c38/0x3150 [ib_uverbs]
    ib_uverbs_ioctl+0x169/0x260 [ib_uverbs]
    __x64_sys_ioctl+0x866/0x14d0
    do_syscall_64+0x3d/0x90
    entry_SYSCALL_64_after_hwframe+0x44/0xae

    Fixes: 514aee660df4 ("RDMA: Globally allocate and release QP memory")
    Link: https://lore.kernel.org/r/2dbb2e2cbb1efb188a500e5634be1d71956424ce.1636631035.git.leonro@nvidia.com
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/verbs.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
    index 89a2b21976d63..20a46d8731455 100644
    --- a/drivers/infiniband/core/verbs.c
    +++ b/drivers/infiniband/core/verbs.c
    @@ -1232,6 +1232,9 @@ static struct ib_qp *create_qp(struct ib_device *dev, struct ib_pd *pd,
    INIT_LIST_HEAD(&qp->rdma_mrs);
    INIT_LIST_HEAD(&qp->sig_mrs);

    + qp->send_cq = attr->send_cq;
    + qp->recv_cq = attr->recv_cq;
    +
    rdma_restrack_new(&qp->res, RDMA_RESTRACK_QP);
    WARN_ONCE(!udata && !caller, "Missing kernel QP owner");
    rdma_restrack_set_name(&qp->res, udata ? NULL : caller);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:55    [W:4.034 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site