Messages in this thread | | | Date | Wed, 24 Nov 2021 10:15:00 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH] fs/locks: fix fcntl_getlk64/fcntl_setlk64 stub prototypes |
| |
On Tue, Nov 23, 2021 at 05:05:07PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > My patch to rework oabi fcntl64() introduced a harmless > sparse warning when file locking is disabled: > > arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct flock64 [noderef] __user *user @@ got struct flock64 * @@ > arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: expected struct flock64 [noderef] __user *user > arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: got struct flock64 * > arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: sparse: incorrect type in argument 4 (different address spaces) @@ expected struct flock64 [noderef] __user *user @@ got struct flock64 * @@ > arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: expected struct flock64 [noderef] __user *user > arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: got struct flock64 * > > When file locking is enabled, everything works correctly and the > right data gets passed, but the stub declarations in linux/fs.h > did not get modified when the calling conventions changed in an > earlier patch. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 7e2d8c29ecdd ("ARM: 9111/1: oabi-compat: rework fcntl64() emulation") > Fixes: a75d30c77207 ("fs/locks: pass kernel struct flock to fcntl_getlk/setlk") > Cc: Christoph Hellwig <hch@lst.de> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
Looks good. Thanks! Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
| |