lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 007/100] usb: musb: tusb6010: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 14651496a3de6807a17c310f63c894ea0c5d858e ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20210915034925.2399823-1-yangyingliang@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/musb/tusb6010.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c
    index 4ecfbf6bb1fa8..902507da8aa85 100644
    --- a/drivers/usb/musb/tusb6010.c
    +++ b/drivers/usb/musb/tusb6010.c
    @@ -1103,6 +1103,11 @@ static int tusb_musb_init(struct musb *musb)

    /* dma address for async dma */
    mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!mem) {
    + pr_debug("no async dma resource?\n");
    + ret = -ENODEV;
    + goto done;
    + }
    musb->async = mem->start;

    /* dma address for sync dma */
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:22    [W:2.309 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site