lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 270/323] usb: host: ohci-tmio: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 9eff2b2e59fda25051ab36cd1cb5014661df657b ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20211011134920.118477-1-yangyingliang@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/ohci-tmio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
    index 983a00e2988dc..702d78e0d903a 100644
    --- a/drivers/usb/host/ohci-tmio.c
    +++ b/drivers/usb/host/ohci-tmio.c
    @@ -196,7 +196,7 @@ static int ohci_hcd_tmio_drv_probe(struct platform_device *dev)
    if (usb_disabled())
    return -ENODEV;

    - if (!cell)
    + if (!cell || !regs || !config || !sram)
    return -EINVAL;

    if (irq < 0)
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:12    [W:4.943 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site