lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 129/323] net: dsa: rtl8366rb: Fix off-by-one bug
    Date
    From: Linus Walleij <linus.walleij@linaro.org>

    [ Upstream commit 5f5f12f5d4b108399130bb5c11f07765851d9cdb ]

    The max VLAN number with non-4K VLAN activated is 15, and the
    range is 0..15. Not 16.

    The impact should be low since we by default have 4K VLAN and
    thus have 4095 VLANs to play with in this switch. There will
    not be a problem unless the code is rewritten to only use
    16 VLANs.

    Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
    Cc: Mauri Sandberg <sandberg@mailfence.com>
    Cc: DENG Qingfang <dqfext@gmail.com>
    Cc: Florian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
    Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/dsa/rtl8366rb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
    index 5aefd7a4696a5..87832e36c3d5a 100644
    --- a/drivers/net/dsa/rtl8366rb.c
    +++ b/drivers/net/dsa/rtl8366rb.c
    @@ -1265,7 +1265,7 @@ static int rtl8366rb_set_mc_index(struct realtek_smi *smi, int port, int index)

    static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan)
    {
    - unsigned int max = RTL8366RB_NUM_VLANS;
    + unsigned int max = RTL8366RB_NUM_VLANS - 1;

    if (smi->vlan4k_enabled)
    max = RTL8366RB_NUM_VIDS - 1;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:02    [W:3.481 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site